Message updates are now full messages . #344
Merged
+80
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the IMessageUpdate interface (and subsequently, its implementation)to implement the IMessageInterface instead of the IPartialMessage interface. This change is due to Discord returning a full message object on MESSAGE_UPDATE. BREAKING-CHANGE: IMessageUpdate now implements IMessage (which implements IPartialMessage), `Mentions` is no longer optional. The ad-hoc implementation for IPartialMessage was kept out of convenience (and to avoid further breaking changes)
Octol1ttle
reviewed
Nov 2, 2024
Backend/Remora.Discord.API.Abstractions/API/Gateway/Events/Messages/IMessageUpdate.cs
Show resolved
Hide resolved
Nihlus
requested changes
Nov 2, 2024
Backend/Remora.Discord.API.Abstractions/API/Gateway/Events/Messages/IMessageUpdate.cs
Show resolved
Hide resolved
Nihlus
added
waiting for author
Apparently it isn't enough to simply use `new` with a different type, at least in C#12
Nihlus
approved these changes
Nov 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the IMessageUpdate interface (and subsequently, its implementation)to implement the IMessageInterface instead of the IPartialMessage interface.
This change is due to Discord returning a full message object on MESSAGE_UPDATE.
BREAKING-CHANGE: IMessageUpdate now implements IMessage (which implements IPartialMessage),
Mentionsis no longer optional. The ad-hoc implementation for IPartialMessage was kept out of convenience (and to avoid further breaking changes)